[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Revert "libxl: Generate golang bindings in libxl Makefile"
- To: Nick Rosbrook <rosbrookn@xxxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Fri, 28 Aug 2020 15:30:11 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5e9Ph/VwqdctE9wAJn/mzJaV+Lq5RBG/S2DRXDiRu/c=; b=as0R8/zHzS9phpBe5Oz16eDrijTYNUz47SY4aavb6pFX7HgKQ4INlA/QFhEwq/K6SnEdImVKTfVK9f/XahmM5lOKY/LSBJNbpT2ESULIpxj42unz+wIEs3FqPjo3vkmzMzRfBRYGdHvTpSU0SQ8XMa97RcU+q/3yNZynJGDVGUMm18yeyVuMoetljZrpl5dqJNC1/N9raQHJsR4fM+T9yUZ/x8eNnhQU0KoHmLNE+L/4H1+iU4o0JhgsT7Zk4H2vwxL5Aunc0nX7s6ERvUmmw6pIhzI+xBm/C3TUcAjbJRIA8GxoWQEoknzi+PdnBmti3QGTagaJBaPbSHVeqUVmwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAhIe4fCY9GRbntsLmNg1O9HRpmeVDc/4P+dYPSmmFJViZ51Rgv1g/3iYmAppg2hBYkbJvO7IOYmNXuerA7TglU6XGUjQn4qLvyCvvggN2fwVArQPla5zQeBNdDDQFamxyU1gN9gkiGe+WQSiRudsCsewYcEvhTlruOwJ30bJ4zV1uKt+Rf+b1NBSoVgJ9P2t1HlHK8Ki1yoc70s7WS/QMK2M/nfj788yiCTF+rayLFX9l4tVZF/nY36oGfgZQ4qWljZbPtMwcVQjJWZE6Tgfejxzj9znGtMmVJNiyVAA6f7LXVtAn4YFEj/WewUFGufn9Mpdt6rZsE89jv3exYT2g==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 28 Aug 2020 15:30:24 +0000
- Ironport-sdr: dkH8vmbkH3ehi7qbTOhIKNARQq523NEpyYe/WY/xbmIYNmNLN8VwrDBe4cuhJ6JRDe2GzGOfhZ qfCmbwkX8Vg19qOHtGcfnEf3LJud3d+DBoYm9+KcXuWG8A/tAbsJCjqiybIEvXe+Fm605rmcsm pALebpnFGFec91m90LkKgGFRqeTWj9i/gJPCFWuhATL1PN3SmnUR3kj/ywgm5u8J/mWe2XJzxL N0zTY2zqlOGldzkHim0yFBmenPeF7n8B1WOghEwI2Xy+isiKK5UuI2RQDnNN2kGw3/pDkHO7EO VPc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWfUmKs/bNNJRlP0m5qFgUgpHdO6lNor0AgAAC6gA=
- Thread-topic: [PATCH] Revert "libxl: Generate golang bindings in libxl Makefile"
> On Aug 28, 2020, at 4:19 PM, Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
>
> On Fri, Aug 28, 2020 at 03:42:48PM +0100, George Dunlap wrote:
>> This reverts commit 60db5da62ac051aab0b217fa2d96acca1cd3ca3e.
>>
>> This is in preparation for the planned move to hosting the xenlight
>> package in a separate repo.
>>
>> This also fixes a regression when building with a read-only source and
>> an out-of-tree build.
>>
>> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
>> ---
>> This is a candidate to backport for 4.14.
>>
>> I was doing prep for writing the infrastructure to create or update an
>> external repo, and figured I might as well send this out now.
>>
>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>> CC: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
>> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> ---
>> tools/golang/xenlight/Makefile | 9 ---------
>> tools/libxl/Makefile | 17 +----------------
>> 2 files changed, 1 insertion(+), 25 deletions(-)
>>
>> diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
>> index eac9dbf12a..8d4d1e97ac 100644
>> --- a/tools/golang/xenlight/Makefile
>> +++ b/tools/golang/xenlight/Makefile
>> @@ -13,15 +13,6 @@ LIBXL_SRC_DIR = ../../libxl
>> .PHONY: all
>> all: build
>>
>> -GOXL_GEN_FILES = types.gen.go helpers.gen.go
> The build target in golang/xenlight/Makefile still uses this variable
> after reverting this patch. $(GOXL_GEN_FILES) will be empty now, meaning
> `make build` will not re-generate *.gen.go if a change was made to
> gengotypes.py.
Oops — good catch. v2 on the way.
-George
|
