Re: [PATCH] Revert "libxl: Generate golang bindings in libxl Makefile"

[Nick Rosbrook <rosbrookn@xxxxxxxxx>]

On Fri, Aug 28, 2020 at 03:42:48PM +0100, George Dunlap wrote:
> This reverts commit 60db5da62ac051aab0b217fa2d96acca1cd3ca3e.
> 
> This is in preparation for the planned move to hosting the xenlight
> package in a separate repo.
> 
> This also fixes a regression when building with a read-only source and
> an out-of-tree build.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
> This is a candidate to backport for 4.14.
> 
> I was doing prep for writing the infrastructure to create or update an
> external repo, and figured I might as well send this out now.
> 
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
>  tools/golang/xenlight/Makefile |  9 ---------
>  tools/libxl/Makefile           | 17 +----------------
>  2 files changed, 1 insertion(+), 25 deletions(-)
> 
> diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
> index eac9dbf12a..8d4d1e97ac 100644
> --- a/tools/golang/xenlight/Makefile
> +++ b/tools/golang/xenlight/Makefile
> @@ -13,15 +13,6 @@ LIBXL_SRC_DIR = ../../libxl
>  .PHONY: all
>  all: build
>  
> -GOXL_GEN_FILES = types.gen.go helpers.gen.go
The build target in golang/xenlight/Makefile still uses this variable
after reverting this patch. $(GOXL_GEN_FILES) will be empty now, meaning
`make build` will not re-generate *.gen.go if a change was made to
gengotypes.py.

-NR