[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/7] x86: don't build with EFI support in shim-exclusive mode


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 19 Aug 2020 09:59:17 +0200
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 19 Aug 2020 08:11:55 +0000
  • Ironport-sdr: OUEdJNbQBzBd7AzviGOBptx6vZkRafMaQJdvVpD3VW3ctuNOKllZ89CLRYIbAAYS3cngbunX7R 7GMJNmOKZlYkmMXrqmtHC0dDNUxnPbE/lc+tJcTlE/hpyc5Kuc6KLkRSW3iWV1U/VYDhGDibPo c8zmaEf8sUZThe241GFYVJbx2IDo/peAFd2HQH0GsTVeJDkxC0SgXRQJqTZdOoeodR7NFs1Ue5 jq5zVFGvyP1C2XfwFf5p37nUDesz9PIBUIsFSYim+T6FjNslcXcrMkherOdnbSsupjGFHwC56g 0CA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Aug 19, 2020 at 09:33:47AM +0200, Jan Beulich wrote:
> On 18.08.2020 15:00, Roger Pau Monné wrote:
> > On Fri, Aug 07, 2020 at 01:32:38PM +0200, Jan Beulich wrote:
> >> There's no need for xen.efi at all, and there's also no need for EFI
> >> support in xen.gz since the shim runs in PVH mode, i.e. without any
> >> firmware (and hence by implication also without EFI one).
> >>
> >> The slightly odd looking use of $(space) is to ensure the new ifneq()
> >> evaluates consistently between "build" and "install" invocations of
> >> make.
> > 
> > I would likely add a comment to the code itself, as it's not obvious
> > without a hint IMO.
> 
> I did indeed consider this, as I agree in principle. The problem is
> where to put such a comment - ahead of the entire macro is not a
> good place imo, and I can't see any other good place either. As a
> result I thought that the use being odd looking will either make
> readers think of why it's there by itself, or direct them towards
> the commit introducing it.

Ahead of the efi-y assignation would be fine for me, but I guess
people would use git blame and find the right commit seeing the kind
of strange construction that we use there.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.