[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/firmware: Fix typo in uninstall target
- To: Hubert Jasudowicz <hubert.jasudowicz@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 19 Aug 2020 08:07:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNvjMurd60zLOvm4fLgGrM26MzhfGHKAxFO+9aWk63I=; b=Cm3J3fSprUBQ0qKB0DmIw4LxOGW1H75PgHWvF5qQSJmmFdAS+qY6X/8D3MlRTLH/9pLIcydnI1GW/TkfMBS2qRZRUHbDcQp9G6uT0UBLkTAMWbxY31oCzRcAIcL0icWs2z7G68kHlNgxTXNyZrx1NV7eQDYbtUanuA3GLkfNivERgvIk93XOjOi78F4n7TU+WddR8tBJaKzrd+afmFHxZDZaEUg4otSG2r233zDCHiKyePk5n5CDRCYB/QLGYFtDoUu7P6YIopG+v0KFHGX0K2G24GBkOKbh45ow1qyBx+etOq6miO/JWY2eWmijlJT/KatmXbqV9S189uFfg6W31Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oRyw1Ant41x++zu6fv1iElDDPUVE+JCLHOVyVDflQkCK7tHzq81dU2HXAvgBbpzzyREAJTZlSEN8dPDzON703Q8MavCvR7yRkWReBQ2+ejP6rd+3YZQwbfWlsEEDuoZDPaD2IHGTbkbaaw3FhgwOEB0TLL92h9pF0h/HV12OWOL/rrDpMTNJfe7wDK8u79/Ak2EXn4XgR9NXUaO4VpezSfDYQ6EIcTJn85RlDPRsZ/oBMtHmX0BtXVJH4jgv49hyiMHLRdoMupC2D97QaO6vKxieb+DZAnpkh8ocaFYGRhDwaiiVUE+VXnDf6CsropH93Ix8a9MlCXYsOryXwy4RXw==
- Authentication-results-original: cert.pl; dkim=none (message not signed) header.d=none;cert.pl; dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, nd <nd@xxxxxxx>
- Delivery-date: Wed, 19 Aug 2020 08:07:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: cert.pl; dkim=none (message not signed) header.d=none;cert.pl; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWdZZYLV0mkUIjl0y+t0BUAAo9j6k/FGkA
- Thread-topic: [PATCH] tools/firmware: Fix typo in uninstall target
> On 18 Aug 2020, at 20:29, Hubert Jasudowicz <hubert.jasudowicz@xxxxxxx> wrote:
>
> When ipxe.bin is missing, make uninstall will fail due to
> wrong switch (-r) passed to rm command. Replace it with -f.
>
Having a make uninstall is quite unusual.
But the modification looks right so ...
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> ---
> tools/firmware/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> index 809a5fd025..1f27117794 100644
> --- a/tools/firmware/Makefile
> +++ b/tools/firmware/Makefile
> @@ -72,7 +72,7 @@ ifeq ($(CONFIG_OVMF),y)
> rm -f $(INST_DIR)/ovmf.bin
> endif
> ifeq ($(CONFIG_IPXE),y)
> - rm -r $(INST_DIR)/ipxe.bin
> + rm -f $(INST_DIR)/ipxe.bin
> endif
> ifeq ($(CONFIG_PV_SHIM),y)
> rm -f $(INST_DIR)/xen-shim
> --
> 2.28.0
>
>
|
