[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: credit2: document that min_rqd is valid and ok to use


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dario Faggioli <dfaggioli@xxxxxxxx>
  • Date: Wed, 22 Jul 2020 15:40:10 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NMIl8jnlh+N2cCXY8SNVvjBNlGZU9fZNkn1UDio7Vh0=; b=RKNA1jZ7fVKKK1heeD+zdGfd8AiEAY/crBE5JuScHKKS16PhcxvPljQr+bhV1s0BsbptJXT8DvtesAeU9E1LN4JtJ0PQlopD+s1WtP/jm97saWaKa0lwbaOedL7i7jJhc6Q/jv9+nGOHINTjHUnq7ZklQpSW/z5hu3kHFW6zLeuQH/TVbC7nPpVgQvvfVNcW5gXn31ioDcDDVYa53F5BpFiNgdbk0EZUaROrESA6x8omIwZYZd6ztdI3XRlGJDr4MOaJLS19GzHtmzmmOF5hq0WoPkluhPtzrS6znl0N5ITjNj4ofycYEVKQIKMqZG3VWL2r+1vOMTteDlz+SB9bkg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kMJ5frpTDFfEhhas2sO0Slcxp+S0TebwJVTnlXDRvmYRpufPe5X8jAH+2ULJJpMT9UkGKXqDs0kt5wAax9uOXJhzhVtot+i8Jn1ulhCR559LpjVt4uMn39ghwQrtJPgGMSZnbjzcAtMkGQcyIMEXAv8Rjs5nM0zXZM2hFsYe4cBGR9uP0h7LfrnOhPXvEWRCDsrAbtJWuWi1USr97u0FNlhCex3NfsW9mYeRsPhh9JNlPR7jT86Bvd+jEYpnduSbRJQHk8h/K3eF2zd1YblL4pwhLlAoHRi5E+6jQ+qQ9F37sW7dwJKHdhBoxg9YnfJvEiIuMgxMJFpzHMqZe6OA/A==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Juergen Gross <JGross@xxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Wed, 22 Jul 2020 15:40:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWYD5i3CiuwX6Cr0uQclh88PJ90g==
  • Thread-topic: [PATCH] xen: credit2: document that min_rqd is valid and ok to use

On Thu, 2020-03-26 at 18:08 +0100, Dario Faggioli wrote:
> Code is a bit involved, and it is not easy to tell that min_rqd,
> inside
> csched2_res_pick() is actually pointing to a runqueue, when it is
> dereferenced.
> 
> Add a comment and an ASSERT() for that.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>
>
Ping.

Actually, for George, this is more a:

<<Hey, it seems I forgot to Cc you when I sent this. Apologies for
that!>> :-)

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.