RE: [PATCH] libxl: tooling expects wrong errno

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu <wl@xxxxxxx>
> Sent: 26 June 2020 12:25
> To: Ian Jackson <ian.jackson@xxxxxxxxxx>
> Cc: paul@xxxxxxx; Roger Pau Monne <roger.pau@xxxxxxxxxx>; 'Grzegorz Uriasz' 
> <gorbak25@xxxxxxxxx>; 'Jan
> Beulich' <jbeulich@xxxxxxxx>; Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; 
> Kevin Tian
> <kevin.tian@xxxxxxxxx>; 'Wei Liu' <wl@xxxxxxx>; jakub@xxxxxxxxxxx; 
> marmarek@xxxxxxxxxxxxxxxxxxxxxx;
> j.nowak26@xxxxxxxxxxxxxxxxx; Anthony Perard <anthony.perard@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; contact@xxxxxxxxxxxx
> Subject: Re: [PATCH] libxl: tooling expects wrong errno
> 
> On Mon, Jun 15, 2020 at 06:39:30PM +0100, Ian Jackson wrote:
> > Paul Durrant writes ("RE: [PATCH] libxl: tooling expects wrong errno"):
> > > > -----Original Message-----
> > > > From: Ian Jackson <ian.jackson@xxxxxxxxxx>
> > > > Thanks for the analysis.  So:
> > > >
> > > > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > > >
> > > > This would seem to be a backport candidate.  AFAICT check has been
> > > > there, looking for ENOSYS, since this code was introduced in
> > > >    826eb17271d3c647516d9944c47b0779afedea25
> > > >    libxl: suppress device assignment to HVM guest when there is no IOMMU
> > > > ?
> > > >
> > > > But that commit has a Tested-by.  Maybe Xen changed its error return
> > > > at some point ?
> > > >
> > >
> > > Yes, it happened in 71e617a6b8f69849c70eda1b3c58f1ff6b244e5a
> > > use is_iommu_enabled() where appropriate...
> >
> > So,
> >
> > Backport: 4.13
> >
> > Thanks!
> 
> This is not yet committed. Paul, can I get a release ack from you?
> 
> Wei.

Yes.

Release-acked-by: Paul Durrant <paul@xxxxxxx>

> 
> >
> > Ian.