Re: [Xen-devel] [PATCH v5 2/4] mm: modify domain_adjust_tot_pages() to better handle a zero adjustment

[Jan Beulich <jbeulich@xxxxxxxx>]

On 29.01.2020 11:16, Paul Durrant wrote:
> Currently the function will pointlessly acquire and release the global
> 'heap_lock' in this case.
> 
> NOTE: No caller yet calls domain_adjust_tot_pages() with a zero 'pages'
>       argument, but a subsequent patch will make this possible.

With this memory_exchange(), as previously indicated, now needlessly
prevents the call when !dec_count. I do think, as said there, that
together with the addition here then redundant checks in callers
should be dropped (and as it looks the named one is the only one).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel