Re: [Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics

[Jan Beulich <jbeulich@xxxxxxxx>]

On 11.10.2019 17:33, Roger Pau Monné  wrote:
> On Fri, Oct 11, 2019 at 04:02:53PM +0100, Andrew Cooper wrote:
>> The virtual address of the base of the IOMMU's regsters is not useful for
>> diagnostic purposes, and is quite voluminous.  The PCI coordinates is by far
>> the most useful piece of identifying information.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Jun Nakajima <jun.nakajima@xxxxxxxxx>
>> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
>> CC: Juergen Gross <jgross@xxxxxxxx>
>>
>> Surrounding printk()s also identify the IOMMU by Xen's internal ID, but that
>> is also pretty useless information when diagnosing problems.
>>
>> RFC for-4.13.  This is a nice to have stylistic improvement.
> 
> I don't think the register is useful for debugging, at least I have
> never used it myself, so:
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Seeing that there hasn't been an ack from Kevin, perhaps this
rather simple change can go in without? Just in case
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel