Re: [Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Oct 11, 2019 at 04:02:53PM +0100, Andrew Cooper wrote:
> The virtual address of the base of the IOMMU's regsters is not useful for
> diagnostic purposes, and is quite voluminous.  The PCI coordinates is by far
> the most useful piece of identifying information.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Jun Nakajima <jun.nakajima@xxxxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> CC: Juergen Gross <jgross@xxxxxxxx>
> 
> Surrounding printk()s also identify the IOMMU by Xen's internal ID, but that
> is also pretty useless information when diagnosing problems.
> 
> RFC for-4.13.  This is a nice to have stylistic improvement.

I don't think the register is useful for debugging, at least I have
never used it myself, so:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel