[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V6 0/8] iommu/arm: Add Renesas IPMMU-VMSA support + Linux's iommu_fwspec
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Julien Grall <Julien.Grall@xxxxxxx>
- Date: Sat, 28 Sep 2019 09:36:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0IAlHnQnBA0CyogNOFMssdKi4VjYKqfQ+2C/diwhYRc=; b=R4BgZamgOTkjpqqlY7UoduzXZPTyLVID6EkuAVrq+D+Avm4vbwoluf/B8T3WDnmtElq5oz6cWwC3YgqRA3wI3UZXBN/h6hecp08bEZaGw60JUD3OuPVl48EQIsTqb1oUkM3gu5481eIHafcRZMy8UCj6ePuhLHsCj4I3EPSZoDpsUogQRklgCSXgiucO1IA86yDGASqsSFB+K8oHI2/YmcuiWzv4yXVfoPJNJPJR1g/QPr7925lLEBzt2cXirucYkkLEGpvmJCLwRE6sa/zgdo44pKOEXCHEi16oNq2j5TF9czRaEpAEwvD2YRimiUhR2IHB8MHBcSQZUgbHhhslJw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+2LkJyKxixUQ9nqbvzKI3vtFfwOG+HAZqg/71lgQm8SfcVQO1dWDEqG7E1SR32dxlf/e3/O5tNJo8s4ZIipruASOV/Iuaupxpm/fLJxlHQNJd1TxnOP1zpGm4ECShhabVYekZMJwk0xye7dbn2t4nf5UyQZQNR9S0dYK7wRazGCkWwNyAjroCfWb2CEMMH+ZBv2JH40UpS3igKJmYOui28pqqCnzjxcQ3agHi+uYC6EhUynkoGtjUcmWaDg/R+8xaOcV/W4skZBtyovGzN3zeY+l5UN8xNHUSQrZ1kiSiF+g9yiowmwprIiK73Svora7A0kGUbXpWwW+CnXzTl6RQ==
- Authentication-results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=none action=none header.from=arm.com;
- Authentication-results-original: spf=none (sender IP is ) smtp.mailfrom=Julien.Grall@xxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>, nd <nd@xxxxxxx>, "volodymyr_babchuk@xxxxxxxx" <volodymyr_babchuk@xxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- Delivery-date: Sat, 28 Sep 2019 09:37:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: True
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Julien.Grall@xxxxxxx;
- Thread-index: AQHVdH1QQzp9/m2u20aSEUYzfut6JKdAIugAgAARc4CAAKMWAA==
- Thread-topic: [PATCH V6 0/8] iommu/arm: Add Renesas IPMMU-VMSA support + Linux's iommu_fwspec
On 28/09/2019 00:52, Oleksandr Tyshchenko wrote:
> сб, 28 сент. 2019 г., 01:50 Stefano Stabellini <sstabellini@xxxxxxxxxx
> <mailto:sstabellini@xxxxxxxxxx>>:
>
> On Thu, 26 Sep 2019, Oleksandr wrote:
> > On 26.09.19 17:56, Julien Grall wrote:
> > > Hi,
> >
> > Hi Julien
> >
> >
> > >
> > > On 9/26/19 12:20 PM, Oleksandr Tyshchenko wrote:
> > > > Oleksandr Tyshchenko (8):
> > > > iommu/arm: Add iommu_helpers.c file to keep common for
> IOMMUs stuff
> > > > iommu/arm: Add ability to handle deferred probing request
> > > > xen/common: Introduce _xrealloc function
> > > > xen/common: Introduce xrealloc_flex_struct() helper macros
> > > > iommu/arm: Add lightweight iommu_fwspec support
> > > > iommu: Order the headers alphabetically in device_tree.c
> > > > iommu/arm: Introduce iommu_add_dt_device API
> > > > iommu/arm: Add Renesas IPMMU-VMSA support
> > >
> > > This series is now merged.
> >
> > Thank you!
>
> I just wanted to provide early feedback that this series causes problems
> with the legacy mmu-masters binding:
>
>
> This series was developed in a way to add new functionality, but not to
> brake existing (legacy bindings). Probably, I missed something
> important. iommu_add_dt_device() could return an error (I assume, this
> is what you are facing) if the device node in DT contains "iommus"
> property (I mean, uses new bindings), but the IOMMU driver doesn't
> implement required callbacks yet. Do the device nodes in your DT contain
> "iommus" property? And to which domain these devices (in your log) are
> going to be assigned (dom0 or other domains?).
Looking at the bindings, I don't think it is legit to have a node using
both legacy and generic binding together. If this is what happens, then
I would consider it as unsupported.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
