Re: [Xen-devel] [PATCH V6 0/8] iommu/arm: Add Renesas IPMMU-VMSA support + Linux's iommu_fwspec

[Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>]

Hi Stefano

Sorry for the possible format issues.

сб, 28 сент. 2019 г., 01:50 Stefano Stabellini <sstabellini@xxxxxxxxxx>:

On Thu, 26 Sep 2019, Oleksandr wrote:
> On 26.09.19 17:56, Julien Grall wrote:
> > Hi,
>
> Hi Julien
>
>
> >
> > On 9/26/19 12:20 PM, Oleksandr Tyshchenko wrote:
> > > Oleksandr Tyshchenko (8):
> > >    iommu/arm: Add iommu_helpers.c file to keep common for IOMMUs stuff
> > >    iommu/arm: Add ability to handle deferred probing request
> > >    xen/common: Introduce _xrealloc function
> > >    xen/common: Introduce xrealloc_flex_struct() helper macros
> > >    iommu/arm: Add lightweight iommu_fwspec support
> > >    iommu: Order the headers alphabetically in device_tree.c
> > >    iommu/arm: Introduce iommu_add_dt_device API
> > >    iommu/arm: Add Renesas IPMMU-VMSA support
> >
> > This series is now merged.
>
> Thank you!

I just wanted to provide early feedback that this series causes problems
with the legacy mmu-masters binding:

This series was developed in a way to add new functionality, but not to brake existing (legacy bindings). Probably, I missed something important. iommu_add_dt_device() could return an error (I assume, this is what you are facing) if the device node in DT contains "iommus" property (I mean, uses new bindings), but the IOMMU driver doesn't implement required callbacks yet. Do the device nodes in your DT contain "iommus" property? And to which domain these devices (in your log) are going to be assigned (dom0 or other domains?).

(XEN) Failed to add /amba/dma@fd500000 to the IOMMU
(XEN) Failed to add /amba/dma@fd510000 to the IOMMU
(XEN) Failed to add /amba/dma@fd520000 to the IOMMU
(XEN) Failed to add /amba/dma@fd530000 to the IOMMU
(XEN) Failed to add /amba/dma@fd540000 to the IOMMU
(XEN) Failed to add /amba/dma@fd550000 to the IOMMU
(XEN) Failed to add /amba/dma@fd560000 to the IOMMU
(XEN) Failed to add /amba/dma@fd570000 to the IOMMU
(XEN) Failed to add /amba/dma@ffa80000 to the IOMMU
(XEN) Failed to add /amba/dma@ffa90000 to the IOMMU
(XEN) Failed to add /amba/dma@ffaa0000 to the IOMMU
(XEN) Failed to add /amba/dma@ffab0000 to the IOMMU
(XEN) Failed to add /amba/dma@ffac0000 to the IOMMU
(XEN) Failed to add /amba/dma@ffad0000 to the IOMMU
(XEN) Failed to add /amba/dma@ffae0000 to the IOMMU
(XEN) Failed to add /amba/dma@ffaf0000 to the IOMMU
(XEN) Failed to add /amba/nand@ff100000 to the IOMMU
(XEN) Failed to add /amba/ethernet@ff0b0000 to the IOMMU
(XEN) Failed to add /amba/ethernet@ff0c0000 to the IOMMU
(XEN) Failed to add /amba/ethernet@ff0d0000 to the IOMMU
(XEN) Failed to add /amba/spi@ff0f0000 to the IOMMU
(XEN) Failed to add /amba/sdhci@ff160000 to the IOMMU
(XEN) Failed to add /amba/sdhci@ff170000 to the IOMMU
(XEN) Failed to add /amba/usb@fe200000 to the IOMMU
(XEN) Failed to add /amba/usb@fe300000 to the IOMMU

Booting fails and also even forcing to continue devices are unusable. I
haven't managed to investigate further.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel