Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen 
hypervisor sysfs-like support"):
> On 27.09.19 12:37, Ian Jackson wrote:
> > I guess that keys will be chosen from some limited safe character
> > set ?  What about values ?  Might we create a key whose value contains
> > binary data ?
> 
> I'd go with "[-A-Za-z0-9@_.:()\[\]#,;]*" for keys

I think this is ASCII printing characters with the exception of
  ! " ` $ % ^ & * = + { } ' ~ < > / \ |

I struggle to find a principled explanation for this particular
exclusion set (apart from /), considering that following are
included:
  - @ _ . : ( ) [ ] # , ;

Could we borrow some existing permitted character set ?  If we are
permitting shell metacharacters why not just permit all printable
ASCII except / ?

> and ASCII for values.

Do you mean "any 7-bit byte", or octet values 32-126 (0x20-0x7e)
inclusive, or something else ?

> > Would it be possible to add a script to xen.git which lists the
> > xenhypfs and checks that all the paths are documented ?  We could add
> > a few calls to that to osstest...
> 
> I'd expect some parts to be described rather generically (as can be seen
> in patch 6 for the runtime parameters). Maybe I should add the entries
> with wildcards there.

That would be nice.

> OTOH adding such a script can easily be done later, maybe with some
> tweaks to the path documentation.

Sure.  Having at least some unit tests ought to be on the roadmap for
supported status, but it doesn't need to happen now.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel