Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

[Jürgen Groß <jgross@xxxxxxxx>]

On 27.09.19 12:37, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH v1 1/6] docs: add feature document for Xen hypervisor 
> sysfs-like support"):
> > On the 2019 Xen developer summit there was agreement that the Xen
> > hypervisor should gain support for a hierarchical name-value store
> > similar to the Linux kernel's sysfs.
> >
> > In the beginning there should only be basic support: entries can be
> > added from the hypervisor itself only, there is a simple hypercall
> > interface to read the data.
> >
> > Add a feature document for setting the base of a discussion regarding
> > the desired functionality and the entries to add.
> Thanks for this work.  Like others, I approve of the basic idea.
>
> Reading your spec document here, I think there is a key part missing:
> please could you specify the allowable syntax for keys, and for
> values.
Yes, that should be done.

> I guess that keys will be chosen from some limited safe character
> set ?  What about values ?  Might we create a key whose value contains
> binary data ?
I'd go with "[-A-Za-z0-9@_.:()\[\]#,;]*" for keys and ASCII for values.

> Depend on the answer to this question, I may want to suggest changes
> or enhancements to your proposed command-line tool.
>
> Also, your top-level document has a list of paths in it, which is
> presumably prospective.  Maybe that information should be a non-parsed
> header section in the paths document ?
Yes, that's better.

> Would it be possible to add a script to xen.git which lists the
> xenhypfs and checks that all the paths are documented ?  We could add
> a few calls to that to osstest...
I'd expect some parts to be described rather generically (as can be seen
in patch 6 for the runtime parameters). Maybe I should add the entries
with wildcards there.

OTOH adding such a script can easily be done later, maybe with some
tweaks to the path documentation.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel