Re: [Xen-devel] [PATCH v7 4/4] xen/x86: Allow stubdom access to irq created for msi.

[Jan Beulich <jbeulich@xxxxxxxx>]

On 25.09.2019 11:41, Roger Pau Monné  wrote:
> On Wed, Sep 25, 2019 at 04:41:26AM +0200, Marek Marczykowski-Górecki wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -254,7 +254,8 @@ void __init clear_irq_vector(int irq)
>>  /*
>>   * Dynamic irq allocate and deallocation for MSI
>>   */
>> -int create_irq(nodeid_t node)
>> +
> 
> Extra newline.
> 
>> +int create_irq(nodeid_t node, bool grant_access)
>>  {
>>      int irq, ret;
>>      struct irq_desc *desc;

I did notice this too (on an earlier version), and it was my
understanding that the addition was deliberate - the comment
is for more than just this one function. I wouldn't insist
on either variant, i.e. I'm fine with the blank line added
and I'm also fine with the addition dropped again.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel