[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 25/47] xen/sched: add runstate counters to struct sched_unit
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Tue, 24 Sep 2019 15:50:11 +0200
- Cc: Tim Deegan <tim@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Sep 2019 13:50:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.09.19 17:27, Jan Beulich wrote:
On 14.09.2019 10:52, Juergen Gross wrote:
@@ -368,7 +372,7 @@ static struct sched_unit *sched_alloc_unit(struct vcpu *v)
unit->vcpu_list = v;
unit->unit_id = v->vcpu_id;
unit->domain = d;
- v->sched_unit = unit;
+ unit->runstate_cnt[v->runstate.state]++;
for ( prev_unit = &d->sched_unit_list; *prev_unit;
prev_unit = &(*prev_unit)->next_in_list )
@@ -384,6 +388,8 @@ static struct sched_unit *sched_alloc_unit(struct vcpu *v)
!zalloc_cpumask_var(&unit->cpu_soft_affinity) )
goto fail;
+ v->sched_unit = unit;
+
return unit;
fail:
Is this movement of the assignment something which really belongs
here, rather than in some earlier patch (perhaps the one actually
introducing it)?
It certainly should be part of an earlier patch.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
