Re: [Xen-devel] [PATCH v3 25/47] xen/sched: add runstate counters to struct sched_unit

[Jan Beulich <jbeulich@xxxxxxxx>]

On 14.09.2019 10:52, Juergen Gross wrote:
> @@ -368,7 +372,7 @@ static struct sched_unit *sched_alloc_unit(struct vcpu *v)
>      unit->vcpu_list = v;
>      unit->unit_id = v->vcpu_id;
>      unit->domain = d;
> -    v->sched_unit = unit;
> +    unit->runstate_cnt[v->runstate.state]++;
>  
>      for ( prev_unit = &d->sched_unit_list; *prev_unit;
>            prev_unit = &(*prev_unit)->next_in_list )
> @@ -384,6 +388,8 @@ static struct sched_unit *sched_alloc_unit(struct vcpu *v)
>           !zalloc_cpumask_var(&unit->cpu_soft_affinity) )
>          goto fail;
>  
> +    v->sched_unit = unit;
> +
>      return unit;
>  
>   fail:

Is this movement of the assignment something which really belongs
here, rather than in some earlier patch (perhaps the one actually
introducing it)?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel