Re: [Xen-devel] [PATCH v3 09/47] xen/sched: move some per-vcpu items to struct sched_unit

[Jürgen Groß <jgross@xxxxxxxx>]

On 19.09.19 17:38, Jan Beulich wrote:
> On 14.09.2019 10:52, Juergen Gross wrote:
> > Affinities are scheduler specific attributes, they should be per
> > scheduling unit. So move all affinity related fields in struct vcpu
> > to struct sched_unit. While at it switch affinity related functions in
> > sched-if.h to use a pointer to sched_unit instead to vcpu as parameter.
> >
> > The affinity_broken flag must be kept per vcpu as it is related to
> > guest actions on specific vcpus. When support of multiple vcpus per
> > sched_unit is being added, a unit is regarded as being subject to
> > "broken affinity" when any of its vcpus has the affinity_broken flag
> > set.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> > V2:
> > - move affinity_broken back to struct vcpu (Jan Beulich)
> > - print affinities only once per unit (Jan Beulich)
> > ---
> >   xen/common/domain.c        | 15 ++------
> >   xen/common/domctl.c        | 13 ++++---
> >   xen/common/keyhandler.c    | 58 ++++++++++++++++--------------
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one minor remark:
>
> > --- a/xen/common/keyhandler.c
> > +++ b/xen/common/keyhandler.c
> > @@ -251,6 +251,7 @@ static void reboot_machine(unsigned char key, struct 
> > cpu_user_regs *regs)
> >   static void dump_domains(unsigned char key)
> >   {
> >       struct domain *d;
> > +    struct sched_unit *unit;
> >       struct vcpu   *v;
> >       s_time_t       now = NOW();
> I can see how it would look a little odd here because of the
> neighboring variables, but generally speaking the new one should
> be pointer to const (and the old ones should have been, too,
> afaict).
Yes. Will change unit for now and the others in - you might have guessed
that already - the ever growing scheduling cleanup series (yes, I'm
noting the topics for that series).


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel