[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v8] x86/emulate: Send vm_event from emulate
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Mon, 9 Sep 2019 11:23:19 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sd7DfyOVo6OStIuT1k3YptRZPoQFW52UTj17mJG5Exw=; b=JZ4+EUvckHBDzzKAcokHN1dRTSpDYPdmVQ0vsN+04K9NwpnchStEX70s11xyT3H6TaFRv94kvbR63xPPoN5YvBEQ83XftCI42R6gNl4Lij+zJysClYFSyd87uNLs6fbiFnLXcdRsLGZHEnSebc6VyRyTmLaSJW4KoJGP3DMtUM+kW6O7c1F3CHjr1YyK1Pi2Fr+bbrtmCCBw61uQwC/1bEzXHQpN9eV+gTSsk0f/hWyHgxYjIM/iwVuFsewz96WxHZhAICNc6NtQQIf3Qyfpddy2vYBaktZxZ7Dfc3o6RUoslKqPPtBLiB0VMF/A1Gt3btMN5dYV47H6Vq6FBljZ3A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VOuOAz/g9pCRee91HDaDfjxa0/GK0iLJ6G9P7F539fug6JF6O1AziomgylpBI2yH/ztHBFJRBABscQdToHKE652JLmzH1xNVx/mbFfoDWpl4Ey4xkhIDCbIjg35rdHcQJwkp5zzBT+ZWkrm3X3WeXpuJj+vU02U8fFuugWEtqyQlsN14+I1cpX5yeUXaQ1PmsKqRj7SrNvDf6FBVRaZKkGIubDmFU2K8zGkUCLpOEGLZ/xj8UtSFPWAYk9/O6D6CGkdtVegKarKHB+6neK23590O3ZXrrRKVFb8SIVNh6lYT3SGqO7u8BRbAY3tGeORlZGbe5+vXxedayDtFPwsjUg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, "tamas@xxxxxxxxxxxxx" <tamas@xxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "paul.durrant@xxxxxxxxxx" <paul.durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 09 Sep 2019 11:23:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVYmAUwzAuH5cfgUOJUZVAs8B/2acez52AgASJFgD//9szgIAANjGA///Q5gCAAAI2gA==
- Thread-topic: [Xen-devel] [PATCH v8] x86/emulate: Send vm_event from emulate
On 09.09.2019 14:15, Jan Beulich wrote:
> On 09.09.2019 13:03, Alexandru Stefan ISAILA wrote:
>>
>>
>> On 09.09.2019 13:49, Jan Beulich wrote:
>>> On 09.09.2019 12:01, Alexandru Stefan ISAILA wrote:
>>>> On 06.09.2019 18:46, Jan Beulich wrote:
>>>>> On 03.09.2019 16:01, Alexandru Stefan ISAILA wrote:
>>>>>> }
>>>>>> + /* Check if eny vm_event was sent */
>>>>>
>>>>> "any" and please add blank line ahead of your addition.
>>>>
>>>> I will correct this.
>>>>
>>>>>
>>>>>> + if ( err )
>>>>>> + goto out;
>>>>>
>>>>> And wait - why does this sit after the loop? Is that a re-basing
>>>>> mistake from when you had put on top of my uncommitted patch?
>>>>
>>>> This is done to skip the mapping part down the line. If there is an
>>>> error then we have to return _it_ and not the mapping.
>>>
>>> But after re-basing you could (and hence imo should) "goto out"
>>> right from the code blob you add to the loop. Which would then
>>> also eliminate the need for other "err" related adjustments you
>>> make.
>>>
>>
>> So you want me to have this patch base on your (x86/HVM: correct
>> hvmemul_map_linear_addr() for multi-page case) patch.
>
> No, explicitly not. The "re-basing" I used above was referring to
> you have moved away from basing your patch on mine.
>
Ok, I misunderstood, thanks for the explanation, I will have the patch
modified as I posted.
Thanks for the review,
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
