[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v8] x86/emulate: Send vm_event from emulate
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Mon, 9 Sep 2019 11:03:59 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RxkzwnkHTD6obctfvif9k7k6duIrBumSddEj7Dbp8vk=; b=PkwTiG94YECcR2DbPcd7JSZtVX4b6H/Mm6oZ82yWdG+6pOshfZF/lTupCGhMHvPKn4TrHGTHPDnRcKJewp+hksMeBtOm4CbwD5Scank40wwBwOGZZs8TpnhVJEBTzlmitXEVs2oq4GksqI/Nyg4mSwE4gJEoToEGDOEb8QQwtpfdsIQCL9W0Sn8yWdl63EiXlBFQKUhgfUUbkEQ1+QQMN4E02s8UUZUQ4FYZEFxBHsDxuHSTIQxDpkX3ERV4S0u9e8KVeoqd3M2KFdbZin6kVzy8a+3+HjYw/9zfCt9OeLXZ6hZVX/XVMd1g3bx4kGmYa6crdAzY3DcSYsUr25+eSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8Q3mpRQ3Bj2O650w6Uqb0DssOj2EkXQz/yaAllcx1jqIT2Z/AYJJDhh9yi0bD47ZV0G4V2FSUVLiGQr2e0F+xg/pCL0xzosvspNi53gs3NUMdEMCmTnKdauWNqFjZ70mLTVvD913u9LhpBt/xPQkFKiArm26sGO5HVMlJGAR6yzLYOkglpAL+r54fg+3INIENUhtPpn/RPYfCi5FhaYwbdRN5ZOnJ0FMiUY7QKSCHM1egxtZyLNlOZXPX5nkCpj3o+SjZAmX2holyvYDGBVFaPaN0IXtkzZ755RSRoCRqZhZqeSgqHwPE+utMb+kjTYF25PO75XwD80LQsw1f8BVw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, "tamas@xxxxxxxxxxxxx" <tamas@xxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "paul.durrant@xxxxxxxxxx" <paul.durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 09 Sep 2019 11:04:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVYmAUwzAuH5cfgUOJUZVAs8B/2acez52AgASJFgD//9szgIAAA+eA
- Thread-topic: [Xen-devel] [PATCH v8] x86/emulate: Send vm_event from emulate
On 09.09.2019 13:49, Jan Beulich wrote:
> On 09.09.2019 12:01, Alexandru Stefan ISAILA wrote:
>> On 06.09.2019 18:46, Jan Beulich wrote:
>>> On 03.09.2019 16:01, Alexandru Stefan ISAILA wrote:
>>>> }
>>>> + /* Check if eny vm_event was sent */
>>>
>>> "any" and please add blank line ahead of your addition.
>>
>> I will correct this.
>>
>>>
>>>> + if ( err )
>>>> + goto out;
>>>
>>> And wait - why does this sit after the loop? Is that a re-basing
>>> mistake from when you had put on top of my uncommitted patch?
>>
>> This is done to skip the mapping part down the line. If there is an
>> error then we have to return _it_ and not the mapping.
>
> But after re-basing you could (and hence imo should) "goto out"
> right from the code blob you add to the loop. Which would then
> also eliminate the need for other "err" related adjustments you
> make.
>
So you want me to have this patch base on your (x86/HVM: correct
hvmemul_map_linear_addr() for multi-page case) patch. Ok, I can do that
in the next version but then it will make the patches dependent and mine
will have to go in after all is resolved in your patch and that could
take some time.
Could I propose to have the goto moved in the loop and when your patch
is ready to merge just replace the err = ERR_PTR(~X86EMUL_RETRY); with
update_map_err(err, ~X86EMUL_RETRY); ?
Thanks,
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
