Re: [Xen-devel] [PATCH v5 3/4] xen: refactor debugtrace data

[Juergen Gross <jgross@xxxxxxxx>]

On 05.09.19 14:13, Jan Beulich wrote:
> On 05.09.2019 13:39, Juergen Gross wrote:
> > --- a/xen/common/debugtrace.c
> > +++ b/xen/common/debugtrace.c
> > @@ -17,34 +17,40 @@
> >   #define DEBUG_TRACE_ENTRY_SIZE   1024
> >   
> >   /* Send output direct to console, or buffer it? */
> > -static volatile int debugtrace_send_to_console;
> > +static volatile bool debugtrace_send_to_console;
> >   
> > -static char        *debugtrace_buf; /* Debug-trace buffer */
> > -static unsigned int debugtrace_prd; /* Producer index     */
> > -static unsigned int debugtrace_kilobytes = 128, debugtrace_bytes;
> > -static unsigned int debugtrace_used;
> > +struct debugtrace_data {
> > +    unsigned long bytes; /* Size of buffer. */
> Hmm, I'm sorry for recognizing this only now, but why does this
> field need replicating? It's the same in all instances of the
> structure afaict.
Oh, right. In the beginning I had plans to support modifying the buffer
size at runtime.

Okay, I'll change it.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel