Re: [Xen-devel] [PATCH 1/2] x86/acpi: Drop sleep_states[] and associated print messages

[Jan Beulich <jbeulich@xxxxxxxx>]

On 02.09.2019 14:11, Andrew Cooper wrote:
> sleep_states[] is a write-only array, and despite the loop logic, the printed
> message is consistently "ACPI sleep modes: S3".  Drop it all.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Albeit FTR I'm not convinced removing the log message is really a
good idea. But we can surely re-instate it if we ever mean to
support things other than S3. The only concern would be whether,
as iirc was suggested somewhere, we may want to allow suppressing
use of S3, in which case the log message might indeed be helpful
even without us supporting other sleep states.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel