Re: [Xen-devel] [PATCH v7 1/6] x86/domain: remove the 'oos_off' flag

[Jan Beulich <jbeulich@xxxxxxxx>]

On 30.08.2019 10:29, Paul Durrant wrote:
> The flag is not needed since the domain 'options' can now be tested
> directly.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> Cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> 
> v3:
>  - Force 'oos_off' to be set for PV guests (to avoid call to
>    is_hvm_domain() except in ASSERT)
>  - Dropped Tim's A-b because of the change

I've been debating with myself whether to not wait any longer for
Tim to re-instate his ack, but now that I've looked again ...

> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -313,11 +313,19 @@ static int sanitise_domain_config(struct 
> xen_domctl_createdomain *config)
>          return -EINVAL;
>      }
>  
> -    if ( !(config->flags & XEN_DOMCTL_CDF_hvm_guest) &&
> -         (config->flags & XEN_DOMCTL_CDF_hap) )
> +    if ( !(config->flags & XEN_DOMCTL_CDF_hvm_guest) )
>      {
> -        dprintk(XENLOG_INFO, "HAP requested for non-HVM guest\n");
> -        return -EINVAL;
> +        if ( config->flags & XEN_DOMCTL_CDF_hap )
> +        {
> +            dprintk(XENLOG_INFO, "HAP requested for non-HVM guest\n");
> +            return -EINVAL;
> +        }
> +
> +        /*
> +         * It is only meaningful for XEN_DOMCTL_CDF_oos_off to be clear
> +         * for HVM guests.
> +         */
> +        config->flags |= XEN_DOMCTL_CDF_oos_off;

... I wonder whether this last part wouldn't better belong into
x86's arch_sanitise_domain_config(). Arm, to the contrary, should
force/require the bit to be uniformly off.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel