Re: [Xen-devel] [PATCH v2] Partially revert "x86/mm: Clean IOMMU flags from p2m-pt code"

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Aug 29, 2019 at 11:33:11AM +0200, Jan Beulich wrote:
> On 29.08.2019 10:49, Roger Pau Monne wrote:
> > @@ -640,9 +670,17 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, 
> > mfn_t mfn,
> >           && (gfn + (1UL << page_order) - 1 > p2m->max_mapped_pfn) )
> >          p2m->max_mapped_pfn = gfn + (1UL << page_order) - 1;
> >  
> > +    if ( need_iommu_pt_sync(p2m->domain) &&
> > +         (iommu_old_flags != iommu_pte_flags || old_mfn != mfn_x(mfn)) )
> > +            rc = iommu_pte_flags ?
> > +                iommu_legacy_map(d, _dfn(gfn), mfn, page_order,
> > +                                 iommu_pte_flags) :
> > +                iommu_legacy_unmap(d, _dfn(gfn), page_order);
> 
> Indentation of the if() body is one level too deep. With this
> corrected (easy enough to do while committing)
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Indeed, my editor seems to have done the wrong thing. Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel