[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] Partially revert "x86/mm: Clean IOMMU flags from p2m-pt code"
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Thu, 29 Aug 2019 09:37:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CEVe2bKK4ZR+fuc0earyn91eDMWCpgVTw4ncRElhXIk=; b=fQ/0P5DTemlespXKOqkMt9WovB8C64YyGHoXl8xp0cGTaLdIbbyey5+Eg0ZA7e8CYa4HH6bB5PoHhIdlFw9ukHW2HmifdTOzSOITd96FrM/0OoWjKosq9tgR9Vt4TfYwem5YN4m7o2vM3zoXd7Le2VtshJFro2HuVU5P+L6juJAimjY28BYszH2pmNaguok+2DRuPTX5O+fm9uTAiZBfK3Sms4CoN86zlYtexZw3gK/cddUXjys4J1SWXneYmN1OWS5YTul+jpkvbFpBeIEl4q/dSzrmO0IPDtCDQLomu1V5wGaxIASkMjlvXtINfZjaFZzM47/ltLOKQ7/M9tg4dA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4xesQe38ZTlIsXHx9bZpMLrvyRV1GUFwfk7FOCPcXA6MEFnZpZye10xysH8FxyPtlWu5PDPyln9jYiEj/diUMhzc/eyVn+rJHWYZLnrnGP06+2hMgd4aKThq3ZvQ9OkPm9az6v2VecHY3KM9X57E+0Msmynde1edK9S6ji6Jw01nIShrZzuwAW77CnJoepHE2HWDCF93i19yuKe1rNcivTBTRwIHafMObK4sBEN670jCXfuUD8ezd1Mo+RSdzHT6XIaKk2zlX/s3q7PrpK98XV8Fx7+IyF73xdYA2RpRpdQKRSqQ7QaIjJ44c6OGeZx1Dh97WkOls1B7z+XenPyjw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Thu, 29 Aug 2019 09:37:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVXkb2wrZEPpiihUuDabdThgmHracR3gwA
- Thread-topic: [PATCH v2] Partially revert "x86/mm: Clean IOMMU flags from p2m-pt code"
On 29.08.2019 11:49, Roger Pau Monne wrote:
> This partially reverts commit
> 854a49a7486a02edae5b3e53617bace526e9c1b1 by re-adding the logic that
> propagates changes to the domain physmap done by p2m_pt_set_entry into
> the iommu page tables. Without this logic changes to the guest physmap
> are not propagated to the iommu, leaving stale iommu entries that can
> leak data, or failing to add new entries.
>
> Note that this commit doesn't re-introduce iommu flags to the cpu page
> table entries, since the logic to add/remove entries to the iommu page
> tables is based on the p2m type and the mfn.
>
> Fixes: 854a49a7486a02 ('x86/mm: Clean IOMMU flags from p2m-pt code')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Cc: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Remove the share-pt branch, there's no sharing on AMD hardware.
> ---
Reviewed-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
