Re: [Xen-devel] [PATCH for-4.11 1/2] XSM: adjust Kconfig names

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.06.19 at 16:11, <julien.grall@xxxxxxx> wrote:
> On 18/06/2019 15:04, Jan Beulich wrote:
>> Since the Kconfig option renaming was not backported, the new uses of
>> involved CONFIG_* settings should have been adopted to the existing
>> names in the XSA-295 series. Do this now, also changing XSM_SILO to just
>> SILO to better match its FLASK counterpart.
>> 
>> To avoid breaking the Kconfig menu structure also adjust XSM_POLICY's
>> dependency (as was also silently done on master during the renaming).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Sorry for the breakage. To avoid such blunder during XSAs, would it be 
> possible 
> to test them on osstest before they are published?

That's an option, but would cause further delays. How exactly to
arrange for this I'm the wrong one to ask, though.

But let's face it: The patch changing Kconfig not having applied
without fuzz should have told whoever did the backport to look
more closely.

What I'd like to ask for in the future in any case though is that after
pushing stuff to stable trees you would please check the osstest
reports, and in case of regressions invest at least some time into
figuring out what broke. Right now, even with the XSM tests
(hopefully) taken care of there's still a flood of armhf failures, which
may or may not be due to environmental issues.

> Also, do we need to update the advisory?

Dunno. I didn't do full analysis of what may go wrong, I've just worked
my way far enough to understand what needs fixing. Whether an
update is needed imo largely depends on whether the purpose of the
patches wasn't fulfilled. People actually using XSM will notice very
quickly that things don't work anymore, as can be seen from the
osstest cases.

> Acked-by: Julien Grall <julien.grall@xxxxxxx>

Thanks, Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel