Re: [Xen-devel] [PATCH v2] xen/arm: Black list everything with a PPI

[Julien Grall <julien.grall@xxxxxxx>]

Hi Amit,

Sorry for the late answer.

Title: "xen/arm: domain_build: Black list devices using PPIs"

On 6/2/19 7:04 PM, Amit Singh Tomar wrote:
> XEN should not forward PPIs to Dom0 as it only support SPIs.
Reading this sentence, it leads to think that Xen does not support PPIs 
at all. However, we are supporting PPIs in Xen but not able to forward 
them directly to a guest.
So how about:

"Currently, the vGIC is not able to cope with hardware PPIs routed to 
guests."
> One of solution to this problem is to skip any device that
s/of solution/of the solutions/

> uses PPI source completely while building domain itself.
s/building domain/building the domain/

> This patch goes through all the interrupt sources of device and skip it
s/of device/of a device/

> if one of interrupt source is PPI. It fixes XEN boot on i.MX8MQ by
"if one of the interrupts sources is a PPI".

> skipping PMU node.
s/PMU/the PMU/

> Suggested-by:  Julien Grall <julien.grall@xxxxxxx>
> Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
> ---
> Changes since v1:
>      * Added comment for PPIs range.
> ---
>   xen/arch/arm/domain_build.c | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d983677..5035758 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1353,7 +1353,7 @@ static int __init handle_node(struct domain *d, struct 
> kernel_info *kinfo,
>           { /* sentinel */ },
>       };
>       struct dt_device_node *child;
> -    int res;
> +    int res, i, nirq, irq_id;
>       const char *name;
>       const char *path;
>   
> @@ -1399,6 +1399,21 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
>           return 0;
>       }
>   
> +    /* Skip the node, using PPI source */
I would add a word explaining why they are skipped:

"The vGIC does not support routing hardware PPIs to guest. So we need to 
skip any nodes using PPIs".
> +    nirq = dt_number_of_irq(node);
> +
> +    for ( i = 0 ; i < nirq ; i++ )
> +    {
> +        irq_id = platform_get_irq(node, i);
> +
> +        /* PPIs ranges from ID 16 to 31 */
> +        if ( irq_id >= 16 && irq_id < 32 )
> +        {
> +            dt_dprintk(" Skip node with (PPI source)\n");
The () looks a bit odd here. If you want to follow the other printk, 
then it should be: "  Skip it (using PPIs)\n"
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel