Re: [Xen-devel] [PATCH v3 09/13] pci: switch pci_conf_read32 to use pci_sbdf_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.06.19 at 11:06, <roger.pau@xxxxxxxxxx> wrote:
> On Thu, Jun 13, 2019 at 08:36:19AM -0600, Jan Beulich wrote:
>> >>> On 07.06.19 at 11:22, <roger.pau@xxxxxxxxxx> wrote:
>> > --- a/xen/drivers/passthrough/vtd/quirks.c
>> > +++ b/xen/drivers/passthrough/vtd/quirks.c
>> > @@ -128,9 +128,11 @@ static void __init map_igd_reg(void)
>> >      if ( igd_reg_va )
>> >          return;
>> >  
>> > -    igd_mmio   = pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_1);
>> > +    igd_mmio   = pci_conf_read32(PCI_SBDF(0, 0, IGD_DEV, 0),
>> 
>> Afaict at this point all uses of IGD_DEV are in constructs like this one.
>> As previously say, I think IGD_DEV itself would now better become an
>> invocation of PCI_SBDF(). Same for IOH_DEV then.
> 
> Is it fine to do this as a followup patch?

Either way is fine by me, albeit I'd (slightly) prefer it getting folded into
here, irrespective ...

> Or else I would also have to modify the pci_conf_read{8,16} calls that
> use IGD_DEV or IOH_DEV in this patch.

... of the need for these extra adjustments.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel