Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

On 11/26/18 4:15 PM, Jan Beulich wrote:
> > > > On 26.11.18 at 17:03, <olaf@xxxxxxxxx> wrote:
> > Am Mon, 26 Nov 2018 03:31:27 -0700
> > schrieb "Jan Beulich" <JBeulich@xxxxxxxx>:
> >
> > > And I think a change like this should (a) address the more general
> > > case rather than just your laptop (or laptops in general) and (b)
> > > actually add some headroom. Hence at the very least I'd see us
> > > go to 4096x3072. WHUXGA would even call for 7680x4800.
> > So should I resend this patch with higher values, or should I remove
> > the bounds check entirely? Not sure what it is trying to achieve, the
> > framebuffer may fail either way if the BIOS provides bogus values.
> I have to forward this question: Stefano introduced all five MAX_*
> values here when splitting out the LFB code in commit e7cb35e8b1
> ("xen: introduce a generic framebuffer driver"). I apparently didn't
> even notice back then that three of them are entirely unused, and
> the two dimension ones had no upper bound before.
>
> Stefano: Why were all of these introduced (there's no explanation
> in the description) and what were the values derived from? Will
> anything break if we remove them?
FWIW, looking at the logs, this was introduced to cater arm framebuffer 
driver. However, we dropped the only driver a few months ago as it was 
not maintained. So x86 is the only user of that code today.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel