Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.11.18 at 20:14, <olaf@xxxxxxxxx> wrote:
> My notebook reports a display size of 1920x1080:
> 
> (XEN) vesafb: framebuffer at 0xd0000000, mapped to 0xffff82c000201000, using 
> 8128k, total 8128k
> (XEN) vesafb: mode is 1920x1080x32, linelength=7680, font 8x16
> (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> 
> The hardcoded values feel arbitrary, so just bump them to fix my system.
> The filters for notebooks at https://geizhals.eu/ indicate the upper
> limit could be even larger, like 3840x2160.

And I think a change like this should (a) address the more general
case rather than just your laptop (or laptops in general) and (b)
actually add some headroom. Hence at the very least I'd see us
go to 4096x3072. WHUXGA would even call for 7680x4800.

> Fixes commit e7cb35e8b1b8f872d906800c72f92f10d701f79c ("xen: introduce a 
> generic framebuffer driver")

I don't think this is appropriate here. Once further bumping turns
out necessary, would that then be a fix to your change here? A
proper "fix" would imo only be to get rid of the hard coded upper
bounds. Bumping the bounds every once in a while is an expected
action.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel