Re: [Xen-devel] [PATCH 2/8] xen/arm: p2m: Introduce p2m_get_page_from_gfn

[Julien Grall <julien.grall@xxxxxxx>]

On 11/15/18 1:31 PM, Andrii Anisov wrote:
> Hello Julien,
Hi,

> вт, 6 лист. 2018 о 21:16 Julien Grall <julien.grall@xxxxxxx> пише:
> > In a follow-up patches, we will need to handle get_page_from_gfn
> > differently for DOMID_XEN. To keep the code simple move the current
> > content in a new separate helper p2m_get_page_from_gfn.
> >
> > Note the new helper is a not anymore a static inline function as the helper
> > is quite complex.
> In the patch "[PATCH 4/8] xen/arm: Add support for read-only foreign
> mappings" you make p2m_get_page_from_gfn() comparingly complex, but
> still keep it as static inline. Could you please be consistent (making
> both of those functions inline or non-inline)
The reason I didn't move the other one in p2m.c is because so far p2m.c 
is only dealing with auto-translated guest. I didn't want to add 
function related with non-auto translated guest in it.
I also don't think introduce a new file for one 10 line function is 
really useful.
So that was the best solution. I am open to other suggestion.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel