Re: [Xen-devel] [PATCH 2/8] xen/arm: p2m: Introduce p2m_get_page_from_gfn

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

Hello Julien,

вт, 6 лист. 2018 о 21:16 Julien Grall <julien.grall@xxxxxxx> пише:
>
> In a follow-up patches, we will need to handle get_page_from_gfn
> differently for DOMID_XEN. To keep the code simple move the current
> content in a new separate helper p2m_get_page_from_gfn.
>
> Note the new helper is a not anymore a static inline function as the helper
> is quite complex.

In the patch "[PATCH 4/8] xen/arm: Add support for read-only foreign
mappings" you make p2m_get_page_from_gfn() comparingly complex, but
still keep it as static inline. Could you please be consistent (making
both of those functions inline or non-inline)

Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel