Re: [Xen-devel] [PATCH v2 03/16] x86: make traps.c build with !CONFIG_PV

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.10.18 at 16:28, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -1337,8 +1339,15 @@ static int fixup_page_fault(unsigned long addr, struct 
> cpu_user_regs *regs)
>      {
>          if ( !(regs->error_code & (PFEC_user_mode | PFEC_reserved_bit)) &&
>               (addr >= GDT_LDT_VIRT_START) && (addr < GDT_LDT_VIRT_END) )
> +        {
> +#ifdef CONFIG_PV
>              return handle_gdt_ldt_mapping_fault(
>                  addr - GDT_LDT_VIRT_START, regs);
> +#else
> +            ASSERT_UNREACHABLE();

I'm not convinced: A buggy access to this range should lead to
an unhandled #PF, not an assertion failure.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel