[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/2] xen/xsm: Add new SILO mode for XSM
>>> On 08.10.18 at 09:49, <xin.li@xxxxxxxxxx> wrote: >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx] >> Sent: Tuesday, October 2, 2018 5:33 PM >> >> >>> On 29.09.18 at 11:22, <talons.lee@xxxxxxxxx> wrote: >> > --- a/xen/xsm/dummy.c >> > +++ b/xen/xsm/dummy.c >> > @@ -11,7 +11,6 @@ >> > */ >> > >> > #define XSM_NO_WRAPPERS >> > -#define XSM_INLINE /* */ >> > #include <xsm/dummy.h> >> >> The change looks unmotivated here, perhaps because of the questionable >> CONFIG_XSM_SILO dependency further up. That said, it looks as if the #define >> could go away currently, as being redundant with what dummy.h already has. >> That would then better be a small separate prereq patch imo. > > This is intended, to avoid compile error, can't refine XSM_INLINE. > Do you mean a separate patch to just remove this line? Yes, and then with an explanation of why this line is not needed. >> > --- /dev/null >> > +++ b/xen/xsm/silo.c >> > @@ -0,0 +1,109 @@ >> > >> +/*************************************************************** >> ***** >> > +********** >> > + * xsm/silo.c >> > + * >> > + * SILO module for XSM(Xen Security Modules) >> >> Would you mind adding the missing blank here? > > Do you mean add one space after XSM? > * SILO module for XSM (Xen Security Modules) Yes. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |