Re: [Xen-devel] [PATCH v2 2/4] x86: split opt_pv_l1tf

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.10.18 at 18:43, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/10/18 13:09, Jan Beulich wrote:
>> Use separate tracking variables for the hardware domain and DomU-s.
>>
>> No functional change intended, but adjust the comment in
>> init_speculation_mitigations() to match prior as well as resulting code.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, but with one
> suggested deletion.
> 
>> @@ -889,18 +892,16 @@ void __init init_speculation_mitigations
>>  
>>      /*
>>       * By default, enable PV domU L1TF mitigations on all L1TF-vulnerable
>> -     * hardware, except when running in shim mode.
>> +     * hardware, except when running in shim mode, and - at least for the
>> +     * time being - also excepting the hardware domain.
> 
> I'm not sure this addition is helpful.  We already state PV domU above.

Oh, right you are - somehow I didn't pay enough attention to the U.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel