Re: [Xen-devel] [PATCH] schedule: move last_run_time to the credit scheduler privates

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Tue, 2018-09-11 at 02:29 -0600, Jan Beulich wrote:
> > > > On 11.09.18 at 10:10, <andrii.anisov@xxxxxxxxx> wrote:
> > 
> > From: Andrii Anisov <andrii_anisov@xxxxxxxx>
> > 
> > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> > index 84e744b..7170172 100644
> > 
> > @@ -701,10 +704,11 @@ static unsigned int vcpu_migration_delay_us;
> >  integer_param("vcpu_migration_delay", vcpu_migration_delay_us);
> >  
> >  static inline bool
> > -__csched_vcpu_is_cache_hot(const struct csched_private *prv,
> > struct vcpu *v)
> > +__csched_vcpu_is_cache_hot(const struct csched_private *prv,
> > +                           struct csched_vcpu * scurr)
> 
> Stray blank, and it looks like the parameter can be pointer to const.
> Similar further down.
> 
And besides this that Jan is saying, I'd name the parameter 'svc'
rather than 'scurr'.

Calling it scurr makes one think that it is always a vcpu that is
currently running on a pcpu which is being passed to the function. But
that, not only is not at all required, but it is not even the case
right now.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel