Re: [Xen-devel] [PATCH] schedule: move last_run_time to the credit scheduler privates

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.18 at 10:10, <andrii.anisov@xxxxxxxxx> wrote:
> From: Andrii Anisov <andrii_anisov@xxxxxxxx>
> 
> The structure member last_run_time is used by a credit scheduler only.
> So move it from a generic vcpu sctructure to the credit scheduler private
> vcpu definition.
> 
> Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
> ---
>  xen/common/sched_credit.c | 12 +++++++++---
>  xen/common/schedule.c     |  1 -
>  xen/include/xen/sched.h   |  3 ---
>  3 files changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> index 84e744b..7170172 100644
> --- a/xen/common/sched_credit.c
> +++ b/xen/common/sched_credit.c
> @@ -175,6 +175,9 @@ struct csched_vcpu {
>      atomic_t credit;
>      unsigned int residual;
>  
> +    /* last time when vCPU is scheduled out */
> +    uint64_t last_run_time;
> +
>  #ifdef CSCHED_STATS
>      struct {
>          int credit_last;
> @@ -701,10 +704,11 @@ static unsigned int vcpu_migration_delay_us;
>  integer_param("vcpu_migration_delay", vcpu_migration_delay_us);
>  
>  static inline bool
> -__csched_vcpu_is_cache_hot(const struct csched_private *prv, struct vcpu *v)
> +__csched_vcpu_is_cache_hot(const struct csched_private *prv,
> +                           struct csched_vcpu * scurr)

Stray blank, and it looks like the parameter can be pointer to const.
Similar further down.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel