Re: [Xen-devel] [PATCH 4/4] x86/iommu: add PVH support to the inclusive options

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.07.18 at 17:15, <roger.pau@xxxxxxxxxx> wrote:
> On Tue, Jul 31, 2018 at 08:52:14AM -0600, Jan Beulich wrote:
>> >>> On 27.07.18 at 17:31, <roger.pau@xxxxxxxxxx> wrote:
>> > +    /* ... or the PCIe MCFG regions. */
>> > +    for ( i = 0; i < pci_mmcfg_config_num; i++ )
>> > +    {
>> > +        unsigned long addr = PFN_DOWN(pci_mmcfg_config[i].address);
>> > +
>> > +        if ( pfn >= addr + (pci_mmcfg_config[i].start_bus_number << 8) &&
>> > +             pfn < addr + (pci_mmcfg_config[i].end_bus_number << 8) )
>> > +            return false;
>> > +    }
>> 
>> Same here - this would better use domain state.
> 
> ... but pci mcfg regions are currently added after the iommu
> initialization in the HVM dom0 builder. I can shuffle that call so
> that iommu initialization is performed after the mcfg regions are
> added.

Or at least leave a todo comment. After all MCFG regions might
further be added while Dom0 boots and parses AML.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel