Re: [Xen-devel] [PATCH v3 3/6] libxc: allow HVM guest to have modules

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 05, 2018 at 11:34:27AM +0100, Wei Liu wrote:
> On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > > Lift the loading code out of PVH specific branch. Take the chance to
> > > make the debug message more useful.  Now the code needs to take into
> > > account virt_base.
> > 
> > I'm afraid this commit message's note about virt_base is a bit opaque,
> > and looks wrong to me.
> > 
> > AIUI you mean something more like
> > 
> >   Now the code needs to handle virt_base being UNSET_ADDR, which it is
> >   for HVM guests.  In that case seg.vstart is interpreted by ???
> >   as an ??? offset from zero ???
> 
> Now the code needs to handle virt_base being UNSET_ADDR, which it is for
> HVM guest. In case PVH and PV, virt_base is set by the respective loader
> by parsing the binary.

In case virt_base is not set, it should be treated as zero.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel