Re: [Xen-devel] [PATCH v3 3/6] libxc: allow HVM guest to have modules

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Wei Liu writes ("[PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> Lift the loading code out of PVH specific branch. Take the chance to
> make the debug message more useful.  Now the code needs to take into
> account virt_base.

I'm afraid this commit message's note about virt_base is a bit opaque,
and looks wrong to me.

AIUI you mean something more like

  Now the code needs to handle virt_base being UNSET_ADDR, which it is
  for HVM guests.  In that case seg.vstart is interpreted by ???
  as an ??? offset from zero ???

(As you can tell, I'm not very familiar with this area fo the code.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel