Re: [Xen-devel] [PATCH 07/13] libx86: Introduce a helper to serialise msr_{domain, vcpu}_policy objects

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.07.18 at 18:56, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 04/07/18 10:16, Jan Beulich wrote:
>>
>>> @@ -325,6 +325,13 @@ typedef struct xen_cpuid_leaf {
>>>  } xen_cpuid_leaf_t;
>>>  DEFINE_XEN_GUEST_HANDLE(xen_cpuid_leaf_t);
>>>  
>>> +typedef struct xen_msr_entry {
>>> +    uint32_t idx;
>>> +    uint32_t flags; /* Reserved MBZ. */
>> ... it remains unclear in this patch whose responsibility it is to clear this
>> field. I wonder whether copy_msr_to_buffer() should make sure of this.
> 
> copy_msr_to_buffer() does explicitly zero this field.
> 
>> +    const xen_msr_entry_t ent = { .idx = idx, .val = val };
> 
> guarantees that the flags field is 0.

Oh, I'm sorry - so it does. I had searched the patch for instances of
"flags" only ...

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel