Re: [Xen-devel] [PATCH 07/13] libx86: Introduce a helper to serialise msr_{domain, vcpu}_policy objects

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.18 at 22:55, <andrew.cooper3@xxxxxxxxxx> wrote:
> From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> As with CPUID, the an architectural form is used for representing the MSR

Stray "the".

Apart from that same remark(s) as for the respective CPUID change,
plus ...

> @@ -325,6 +325,13 @@ typedef struct xen_cpuid_leaf {
>  } xen_cpuid_leaf_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_cpuid_leaf_t);
>  
> +typedef struct xen_msr_entry {
> +    uint32_t idx;
> +    uint32_t flags; /* Reserved MBZ. */

... it remains unclear in this patch whose responsibility it is to clear this
field. I wonder whether copy_msr_to_buffer() should make sure of this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel