Re: [Xen-devel] [PATCH v9 03/11] x86/hvm: Introduce hvm_save_cpu_ctxt_one func

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.18 at 14:05, <aisaila@xxxxxxxxxxxxxxx> wrote:
> On Vi, 2018-06-29 at 10:00 -0600, Jan Beulich wrote:
>> > > > On 28.06.18 at 11:25, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> > --- a/xen/include/asm-x86/hvm/support.h
>> > +++ b/xen/include/asm-x86/hvm/support.h
>> > @@ -52,6 +52,8 @@ extern unsigned int opt_hvm_debug_level;
>> >  #define HVM_DBG_LOG(level, _f, _a...) do {} while (0)
>> >  #endif
>> >
>> > +#define CONTINUE 2
>> This is way too generic an identifier name. And it's not helpful at
>> all without other possible values also enumerated. And please
>> take "enumerated" as a hint ... Otoh, looking at its use - this is
>> an agreement between hvm_save_cpu_ctxt() and
>> hvm_save_cpu_ctxt_one() only. Why does such need a globally
>> visible #define?
>>
> 
> In the first patches(introduce*) it is used only between save*() and
> save_one*() funcs but later in patch 9 it is used in hvm_save() so it
> has to be visible from both places. I can move the enum(for the return
> values) declaration to save.h if that is a good place for it.

Yes, this would be more suitable a place.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel