Re: [Xen-devel] [PATCH v1 02/15] arm64: Add config for Cavium Thunder erratum 30115

[Julien Grall <julien.grall@xxxxxxx>]

On 03/21/2018 05:06 AM, Manish Jaggi wrote:
> On 03/20/2018 01:13 PM, Julien Grall wrote:
> > On 03/16/2018 11:58 AM, Manish Jaggi wrote:
> > > diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
> > > index fe9e9facbe..d49698f785 100644. 
> > > --- a/xen/arch/arm/cpuerrata.c
> > > +++ b/xen/arch/arm/cpuerrata.c
> > > @@ -56,6 +56,27 @@ static const struct arm_cpu_capabilities 
> > > arm_errata[] = {
> > >           MIDR_RANGE(MIDR_CORTEX_A57, 0x00,
> > >                      (1 << MIDR_VARIANT_SHIFT) | 2),
> > >       },
> > > +#endif
> > > +#ifdef CONFIG_CAVIUM_ERRATUM_30115
> > > +    {
> > > +        /* Cavium ThunderX, T88 pass 1.x - 2.2 */
> > This is quite odd. You specify a number in the commit message here, 
> > but in the previous one you just say "thunderx1". Can you please try 
> > to agree on the name? Like the right naming is MIDR_THUNDERX_88.
> ThunderX1 is 88xx. Also this patch is using the same patch from linux.
> Please see
> https://lists.cs.columbia.edu/pipermail/kvmarm/2017-June/025815.html
If you re-use a patch from Linux then write it in the commit message... 
And in patch #1, you should clarify you are re-using Linux name.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel