Re: [Xen-devel] [PATCH] tools/libxl: Fix assertion failure when trying to build a nested-virt PVH domain

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jan 26, 2018 at 07:23:52PM +0000, Andrew Cooper wrote:
> On 26/01/18 19:11, Ian Jackson wrote:
> > Andrew Cooper writes ("[PATCH] tools/libxl: Fix assertion failure when 
> > trying to build a nested-virt PVH domain"):
> >> xl: libxl.c:339: libxl_defbool_val: Assertion 
> >> `!libxl_defbool_is_default(db)' failed.
> >>
> >> This happens because initiate_domain_create() checks for type != HVM, then
> >> pokes at the hvm union.  Check for == HVM instead so the union access is
> >> correctly guarded.
> >>
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >
> > This bug will be in a lot of stable branches.  Do we care about fixing
> > this bug for them ?  It's UB in libxl but only if nested_hvm is enabled.
> 
> I'm not the check is overly old to begin with.  We should probably fix
> it in the maintained branches.

AFAICT this was introduced by my type = 'pvh' work, sorry. It should
only need backporting to 4.10 and the 4.8.3pre-shim-comet branches.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel