Re: [Xen-devel] [PATCH] tools/libxl: Fix assertion failure when trying to build a nested-virt PVH domain

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("[PATCH] tools/libxl: Fix assertion failure when trying 
to build a nested-virt PVH domain"):
> xl: libxl.c:339: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' 
> failed.
> 
> This happens because initiate_domain_create() checks for type != HVM, then
> pokes at the hvm union.  Check for == HVM instead so the union access is
> correctly guarded.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

This bug will be in a lot of stable branches.  Do we care about fixing
this bug for them ?  It's UB in libxl but only if nested_hvm is enabled.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel