Re: [Xen-devel] [PATCH v2 for-next 6/9] kconfig/gcov: rename to coverage

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Nov 16, 2017 at 05:22:43PM -0500, Konrad Rzeszutek Wilk wrote:
> On Thu, Nov 09, 2017 at 11:13:46AM +0000, Roger Pau Monne wrote:
> > diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> > index 7bb0465b5d..153d68fed3 100644
> > --- a/xen/Kconfig.debug
> > +++ b/xen/Kconfig.debug
> > @@ -28,12 +28,11 @@ config FRAME_POINTER
> >       maybe slower, but it gives very useful debugging information
> >       in case of any Xen bugs.
> >  
> > -config GCOV
> > -   bool "Gcov Support"
> > +config COVERAGE
> > +   bool "Code coverage support"
> >     depends on !LIVEPATCH
> > -   select SUPPRESS_DUPLICATE_SYMBOL_WARNINGS
> 
> Any particular reason this was removed?
> 
> Or is the idea that the coverage technology should have this select?

That's my fault, I will add the select back.

> > diff --git a/xen/include/xen/coverage.h b/xen/include/xen/coverage.h
> > index daddef37d3..098f116760 100644
> > --- a/xen/include/xen/coverage.h
> > +++ b/xen/include/xen/coverage.h
> > @@ -1,9 +1,14 @@
> >  #ifndef _XEN_COV_H
> >  #define _XEN_COV_H
> >  
> > -#ifdef CONFIG_GCOV
> > +#ifdef CONFIG_COVERAGE
> >  #include <public/sysctl.h>
> >  int sysctl_cov_op(struct xen_sysctl_coverage_op *op);
> > +#else
> > +static inline int sysctl_cov_op(void *unused)
> > +{
> > +    return -ENOSYS;
> 
> Not -EOPNOTSUPP ?

IIRC for non implemented top-level hypercalls Xen returns ENOSYS
instead of EOPNOTSUPP, but I might be wrong.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel