[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__
On Wed, Nov 8, 2017 at 7:00 AM, Eric Blake <eblake@xxxxxxxxxx> wrote: > On 11/08/2017 08:51 AM, Alistair Francis wrote: > >>>>> Let me rephrase the question: do we really support compilers that don't >>>>> understand __func__? The presence of numerous unconditional uses of >>>>> __func__ in the tree means the answer is no. Let's replace AUDIO_FUNC >>>>> by plain __func__. >>>> >>>> Answered elsewhere in patch 3/46 (where we DO replace AUDIO_FUNC by >>>> __func__). >>> >>> I see. >>> >>> Put 03/46 first, so we don't have to mess with AUDIO_FUNC twice? >> >> I would really like to avoid that, as the conflicts will be a bit of a >> mess. The way I see it there will be a lot of churn no matter what, >> so we don't gain much by swapping the order around. >> >> I have a new series ready to send today, so I'm going to send that >> through as I would like at least some of these patches to make it in >> 2.11. After that if you think strongly the order should be changed I >> can change it in the next version. > > I think the reorder is not that hard. Put 3/46 first (changing > AUDIO_FUNC to __func__), and then 1/46 doesn't have to touch any of the > files that used to use AUDIO_FUNC, because there is no intermediate > state using __FUNCTION__. > > If I'm reading it correctly, the rebase conflict is limited to a slight > rewording of the commit message for 3/46, and one line in 1/46 to the > definition of AUDIO_FUNC (that will no longer be present). That's true, it didn't end up being that hard. I'm launching my tests now, so I should be able to send the series out later today. Hopefully some of this can make it in 2.11 :) Thanks, Alistair > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |