Re: [Xen-devel] [PATCH for-next 5/9] coverage: introduce generic file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.10.17 at 11:19, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/common/coverage/Makefile
> +++ b/xen/common/coverage/Makefile
> @@ -1,4 +1,4 @@
> -obj-y += gcov_base.o gcov.o
> +obj-y += gcov_base.o gcov.o coverage.o

These would better be sorted, too.

> --- a/xen/include/xen/coverage.h
> +++ b/xen/include/xen/coverage.h
> @@ -9,6 +9,7 @@ struct cov_sysctl_ops {
>      void     (*reset_counters)(void);
>      int      (*dump)(XEN_GUEST_HANDLE_PARAM(char), uint32_t *);
>  };
> +extern struct cov_sysctl_ops cov_ops;

I don't think this is the right place to put this declaration (and
perhaps also the struct one) - it's not part of the outside
visible interface of the coverage code, but an internal aspect.
Such should live in a private header, unless they need to be
exposed to e.g. arch specific code (which doesn't appear to
be the case here).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel