Re: [Xen-devel] [PATCH for-next 5/9] coverage: introduce generic file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.10.17 at 17:57, <roger.pau@xxxxxxxxxx> wrote:
> On Mon, Oct 30, 2017 at 04:48:21PM +0000, Wei Liu wrote:
>> On Thu, Oct 26, 2017 at 10:19:34AM +0100, Roger Pau Monne wrote:
>> > --- /dev/null
>> > +++ b/xen/common/coverage/coverage.c
>> > @@ -0,0 +1,71 @@
>> > +/*
>> > + * Generic functionality for coverage analysis.
>> > + *
>> > + * Copyright (C) 2017 Citrix Systems R&D
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> > + * modify it under the terms and conditions of the GNU General Public
>> > + * License, version 2, as published by the Free Software Foundation.
>> > + *
>> > + * This program is distributed in the hope that it will be useful,
>> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> > + * General Public License for more details.
>> > + *
>> > + * You should have received a copy of the GNU General Public
>> > + * License along with this program; If not, see 
>> > <http://www.gnu.org/licenses/>.
>> > + */
>> > +
>> > +#include <xen/errno.h>
>> > +#include <xen/guest_access.h>
>> > +#include <xen/types.h>
>> > +#include <xen/coverage.h>
>> 
>> Please sort this.
> 
> OK, I will have to include type.h in coverage.h then.

But that's not something depending on the ordering request: No
matter that we have many examples to the contrary, headers
(at least non-private ones) shouldn't really rely on other things
to have been included up front.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel