Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-i386-pvgrub

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Nov 06, 2017 at 01:47:56PM +0000, osstest service owner wrote:
> branch xen-unstable
> xenbranch xen-unstable
> job test-amd64-amd64-i386-pvgrub
> testid guest-start
> 
> Tree: linux git://xenbits.xen.org/linux-pvops.git
> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> Tree: xen git://xenbits.xen.org/xen.git
> 
> *** Found and reproduced problem changeset ***
> 
>   Bug is in tree:  xen git://xenbits.xen.org/xen.git
>   Bug introduced:  f48b5449dabc770acdde6d25cfbd265cfb71034d
>   Bug not present: 86cf189a957129ea1ad6468fe9a0887b9e2819f3
>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/115612/
> 
> 
>   commit f48b5449dabc770acdde6d25cfbd265cfb71034d
>   Author: Wei Liu <wei.liu2@xxxxxxxxxx>
>   Date:   Thu Oct 12 20:19:07 2017 +0100
>   
>       tools/dombuilder: Switch to using gfn terminology for console and 
> xenstore rings
>       
>       The sole use of xc_dom_translated() and xc_dom_p2m() outside of the 
> domain
>       builder is for libxl_dom() to translate the console and xenstore pfns 
> back
>       into useful values.  PV guest pfns are only interesting to the domain 
> builder,
>       and gfns are the address space used by all other hypercalls.
>       
>       Renaming the fields in xc_dom_image is deliberate, as it will cause
>       out-of-tree users of the dombuilder to notice the different semantics.
>       
>       Correct the terminology throughout xc_dom_gnttab{_hvm,}_seed(), which 
> are all
>       using gfns despite the existing variable names.
>       
>       Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>       Reviewed-by: Roger Pau Monn?? <roger.pau@xxxxxxxxxx>
>       Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>       Tested-by: Julien Grall <julien.grall@xxxxxxx>
>       Release-acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
>       [ wei: fix stubdom build ]
>       Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

This has broken pvgrub. The problem is more than just the name of the
variables. I have reverted this and its successor patch.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel